Fix for style change crash, and code cleanup

[Maciej Stachowiak]

On Oct 4, 2003, at 9:20 AM, Dirk Mueller wrote:

> On Friday 03 October 2003 18:57, Maciej Stachowiak wrote:
>
>> 1) operator++ still has to be changed to a method that takes an
>> argument, because it depends on what used to be global statel. So the
>> .increment( bidi ) would just turn into .increment( this ).
>
> Well, you could fix that by letting the iterator store a pointer to 
> the Bidi
> state object. I'm not sure if its worth it though, but it would 
> produce nicer
> looking code.

Yeah, I didn't do it that way because I wasn't sure if it was safe. It 
doesn't look like iterators can last across layouts any more with my 
change, but I'm not 100% sure.

> Maybe "next" is a better name than increment btw.

Sounds fine to me.

I'll take your suggestions in my next round of cleanup.

>> Hey, it didn't even take me 5 hours to code it, so I'd be surprised if
>> it took 5 hours to apply. :-)
>
> Did you ever read the diff between the Safari and the Konqueror 
> version of
> bidi.cpp? Its like removing all the lines, and adding them all back in.

Sure, but I think this particular patch could be applied manually in 
less than 5 hours. Still, it might be nice to get those baseline diffs 
reduced.

  - Maciej