Fix for style change crash, and code cleanup

[Dirk Mueller]

On Thursday 02 October 2003 21:02, Maciej Stachowiak wrote:

> I fixed this by refactoring the code to put most of the global
> variables in a struct allocated on the stack, and pass around a
> reference to the struct. Seems much cleaner (if somewhat wordier) this
> way. 

I don't think that things like

-    ++eor;
+    bidi.eor.increment( bidi );

can be called a code cleanup. What would be correct is to actually create a 
class with those member variables, and turn the static helper functions into 
members of this BidiState class. 

In addition it would cut down the size of your patch by at least 80% and make 
it somehow possible to merge for me in less than 5 hours of manual conflict 
resolution. It would also ease further code cleanups. 

-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <