patch for 'cssFloat'

[Dirk Mueller]

On Wednesday 01 October 2003 22:34, David Hyatt wrote:

> +  bool pixelOrPos;
> +  DOM::DOMString p = cssPropertyName(propertyName, &pixelOrPos);

I think you missed one case to fix. 

>     DOM::CSSValue v = styleDecl2.getPropertyCSSValue(p);
>     if (!v.isNull()) {
> -    if (asNumber && v.cssValueType() ==
> DOM::CSSValue::CSS_PRIMITIVE_VALUE)
> +    if (pixelOrPos && v.cssValueType() ==
> DOM::CSSValue::CSS_PRIMITIVE_VALUE)
>         return
> Number(static_cast<DOM::CSSPrimitiveValue>(v).getFloatValue(DOM::
> CSSPrimitiveValue::CSS_PX));
>
>       return getStringOrNull(v.cssText());

Argh, this code is again different in our tree. Any chance that you could 
enlighten us why this was changed in your tree?

> -void DOMCSSStyleDeclaration::tryPut(ExecState *exec, const Identifier
> &pName, const Value& value, int )
> +void DOMCSSStyleDeclaration::tryPut(ExecState *exec, const Identifier
> &propertyName, const Value& value, int )
>   {
> -  Identifier propertyName = pName;

and this is safe here?

BTW, could you please attach the diffs instead of posting them inline? Your 
mail agent wraps them in fancy ways which makes it very difficult to read and 
to apply. 


-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <