Latest layer patch

Dirk Mueller mueller at kde.org
Thu Oct 2 01:09:39 CEST 2003


On Tuesday 02 September 2003 19:52, David Hyatt wrote:

> Here's the latest layer patch.  I fixed another clipping bug with
> relative positioning, and I optimized relpositioning to only do a
> repaint when left/top/right/bottom changes and not a layout.  This
> patch also fixes a couple of hover-related crashes introduced by the
> last revision of the patch.

Hmm, whats the point storing the hover node separately?

Also, looking at the patch it is quite difficult to merge. Could you at least 
please merge the comment and code style fixes? We also fixed some of the 
method and variable names, it would be great if we could at least standardize 
the naming sheme, because otherwise the merges produce increasing headaches. 

I still don't see the reason for splitting the zorder lists into two, but I 
don't particularly care .. I think however doing it with one list is less 
prone to errors. 

BTW, any chance that you could adjust the overflow: scroll code to our (Qt) 
naming style? Things like "setKnobPosition" or how that thing is called does 
not really exist here..

Thanks, and really many thanks for posting your changes here. Great!

-- 
> Looking for a KDE-related EMail-Alias ? Get one at kdemail.net for FREE! <


More information about the Khtml-devel mailing list