Invalid css property values

Harri Porten porten at froglogic.com
Fri Nov 28 23:31:14 CET 2003


Hi,

Stephan Kulow noticed that any attempt to set a style sheet property to an
invalid value via JavaScript is ignored. The attached patch removes a
removeProperty() call. The real removal is done in CSSParser::parseValue()
only _after_ the value has been validated.

Fixes a test case distilled from a real world web page (sport1.de). Page
still doesn't work yet which is likely due to a distillation error ;)

Harri.
-------------- next part --------------
Index: css/css_valueimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/css/css_valueimpl.cpp,v
retrieving revision 1.90
diff -u -3 -p -r1.90 css_valueimpl.cpp
--- css/css_valueimpl.cpp	24 Nov 2003 16:47:28 -0000	1.90
+++ css/css_valueimpl.cpp	28 Nov 2003 10:19:31 -0000
@@ -294,7 +294,6 @@ bool CSSStyleDeclarationImpl::setPropert
 	m_lstValues = new QPtrList<CSSProperty>;
 	m_lstValues->setAutoDelete(true);
     }
-    removeProperty(id, nonCSSHint );
 
     CSSParser parser( strictParsing );
     bool success = parser.parseValue( this, id, value, important, nonCSSHint );


More information about the Khtml-devel mailing list