patches: many performance improvements

Maciej Stachowiak mjs at apple.com
Fri Nov 21 21:36:37 CET 2003


On Nov 21, 2003, at 4:13 AM, David Faure wrote:

>
> Waldo applied the first one and found a mistake in it.
> His version says:
> -    m_clients.remove(c);
> -    m_clients.append(c);
> +    m_clients.replace(c,c);
> and it should indeed be replace() instead of insert(), otherwise the 
> QPtrDict
> will have duplicates of "c" multiple times in it (at least with the 
> standard QPtrDict behavior ;)

OK, I'll change it in the Safari tree. Our QPtrDict doesn't have that 
behavior for insert so I hope nothing in khtml is counting on it...

Regards,
Maciej
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2355 bytes
Desc: not available
Url : https://mail.kde.org/mailman/private/khtml-devel/attachments/20031121/d4805544/smime.bin


More information about the Khtml-devel mailing list