patch that fixes an obscure problem with array.sort
porten at froglogic.com
porten at froglogic.com
Mon Nov 10 18:20:52 CET 2003
On Mon, 10 Nov 2003, Darin Adler wrote:
> Here's a patch for a small array.sort bug in kjs.
Will take a look later.
> In the next week or two if I can find the time I plan to make changes
> so that JavaScriptCore is much closer to kjs tip of tree. For any
Great !
> places where the two differ in a way that's irrelevant to the generated
> code, I'm going to adopt the current kjs.
Feel free to ask if you have any questions.
One thing I was going to ask you is to change the Node::evaluate()
signature to look like:
virtual Value evaluate(ExecState *exec) const;
I added the const a few months ago. The virtual keyword is optional of
course but if you adapt it the diff will be much smaller.
I'll probably back out some optimization changes I made in nodes.*
(toBoolean() etc.). These functions help to avoid some superfluous object
creations. I was able to measure a positive effect but continuing this
route would mean to write a lot more code. It might not have been the best
idea to tackle optimizations at this level in the code.
Harri.
More information about the Khtml-devel
mailing list