patch: fix for <tr> cells attribute

Maciej Stachowiak mjs at apple.com
Mon Nov 3 23:52:31 CET 2003


FYI I just landed this recently, but I see it's fixed already in khtml 
HEAD.

-------------- next part --------------
Index: ChangeLog
===================================================================
RCS file: /local/home/cvs/Labyrinth/WebCore/ChangeLog,v
retrieving revision 1.2161
diff -u -p -r1.2161 ChangeLog
--- ChangeLog	2003/10/31 00:11:44	1.2161
+++ ChangeLog	2003/10/31 00:40:01
@@ -1,3 +1,13 @@
+2003-10-30  Maciej Stachowiak  <mjs at apple.com>
+
+        Reviewed by Darin.
+
+	- fixed 3426081 - empty cells HTMLCollection for <tr>
+	- fixed 3367598 - "length" attribute for table row "cells" always returns 0
+	
+        * khtml/dom/html_table.cpp:
+        (HTMLTableRowElement::cells): TR_CELLS, not TABLE_ROWS.
+
 2003-10-30  David Hyatt  <hyatt at apple.com>
 
 	Fix for 3468916, outline needs its own paint action so that focus rings don't draw under other content.
Index: khtml/dom/html_table.cpp
===================================================================
RCS file: /local/home/cvs/Labyrinth/WebCore/khtml/dom/html_table.cpp,v
retrieving revision 1.5
diff -u -p -r1.5 khtml/dom/html_table.cpp
--- khtml/dom/html_table.cpp	2003/01/17 22:42:07	1.5
+++ khtml/dom/html_table.cpp	2003/10/31 00:40:01
@@ -677,7 +677,7 @@ void HTMLTableRowElement::setSectionRowI
 HTMLCollection HTMLTableRowElement::cells() const
 {
     if(!impl) return HTMLCollection();
-    return HTMLCollection(impl, HTMLCollectionImpl::TABLE_ROWS);
+    return HTMLCollection(impl, HTMLCollectionImpl::TR_CELLS);
 }
 
 void HTMLTableRowElement::setCells( const HTMLCollection & /*_cells*/ )


More information about the Khtml-devel mailing list