Patch for removeAttributeNode

David Faure faure at kde.org
Fri Jun 27 22:00:14 CEST 2003


On Friday 27 June 2003 18:56, David Faure wrote:
> Hmm, I see that ElementImpl::removeAttribute() doesn't use that return value, so this
> feels like a waste of time, doing it in removeNamedItem. I should rather change
> removeNamedItem to return void, and do the cloning in removeAttributeNode, no?

This patch implements that solution. Is it better? For a small speedup in removeAttribute(),
it duplicates a little bit of code, and I hope my NamedNodeMap::removeNamedItemNS code
is correct. Which version should I commit?

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html


More information about the Khtml-devel mailing list