Konqueror, Safari and Opera (fwd)

[David Faure]

On Saturday 21 June 2003 08:32, Curt Arnold wrote:
> Safari and Opera would run the tests without crashing, but did not 
> display the details of the test errors and failures in either the main 
> form or when using the "Show All" button.  This appears to be a problem 
> with JSUnit on those browsers since the same behavior can be seen when 
> trying to run the JSUnit self-test jsUnitTestFailures.html.

Actually, it's a bug in KHTML's importNode implementation.
This fixes it - Peter, can you confirm this patch is correct?

Index: dom_docimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/xml/dom_docimpl.cpp,v
retrieving revision 1.228
diff -u -p -r1.228 dom_docimpl.cpp
--- dom_docimpl.cpp     21 Jun 2003 09:14:53 -0000      1.228
+++ dom_docimpl.cpp     21 Jun 2003 21:37:51 -0000
@@ -503,7 +503,7 @@ NodeImpl *DocumentImpl::importNode(NodeI
                    // attr was created via createElement()
                    DOMString name = otherDoc->attrNames()->getName(otherAttr->attrId());
                    NodeImpl::Id id = m_attrNames->getId(name.implementation(),false);
-                   tempElementImpl->setAttribute(id,0,0,otherAttr->nodeName().implementation(),
+                   tempElementImpl->setAttribute(id,0,0,otherAttr->nodeValue().implementation(),
                                                  exceptioncode);
                }

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html