Small patch

[Darin Adler]

On Wednesday, July 30, 2003, at 03:36 PM, Daniel Molkentin wrote:

> Danimo pointed me to to kjs/simple_number.h that is a good example of 
> something that's very 64 bit unclean.

I didn't think the original was 64-bit unclean.

I looked at your patch, and it looks OK, but I don't understand the 
problem with the original.

There's no need to keep the sign bit in the very highest bit of the 
64-bit pointer. I want to keep it in bit 31, no matter how big the 
integer is. The value() function is supposed to deal with this by 
extending that sign bit up to all the higher order bits of the long 
integer by or-ing in ~max, which is 111...000...

Could you give a specific example of exactly how the original fails, so 
I can understand my mistake?

     -- Darin