kjs static patches

Harri Porten porten@trolltech.com
Sat, 25 Jan 2003 02:10:14 +0100 (CET)


On Fri, 24 Jan 2003, Darin Adler wrote:

> > 1st patch: the hash tables. I advice to do the same in khtml/ecma via
> > search&replace.
> 
> These tables are generated by create_hash_table script. You almost 
> certainly want to change that script and re-run it rather than patching 
> each file.

As you like. The patch modifies the script, too.

> > 2nd patch: two local vars introduced in JavaScriptCore
> 
> In C++, something declared as "const int x = 1;" is automatically 
> static. You'd have to explicitly say "extern const int x = 1;" 
> otherwise. You don't need to add static to these declarations, although 
> they do no harm.

That's news to me. Explains why the symbols were already of local type
when I examined the library.

Harri.