Number Object patch
Harri Porten
porten@trolltech.com
Fri, 17 Jan 2003 00:59:47 +0100 (CET)
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.
---397395163-1972808330-1042761587=:28184
Content-Type: TEXT/PLAIN; charset=US-ASCII
Hi !
I noticed that the constructors of *InstanceImp classes in JavaScriptCore
have been optimized to just take an ObjectImp pointer argument. As a side
note: the implicit Object conversion was probably never intended (Peter?)
and only surfaced when the Object(ObjectImp*) ctor was made "explicit"
afterwards.
The change hasn't been made in NumberInstanceImp. Attached you'll find a
small diff that brings all instance implementations in line.
Harri.
---397395163-1972808330-1042761587=:28184
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="number_object.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.10.10301170059470.28184@lupinella.troll.no>
Content-Description:
Content-Disposition: attachment; filename="number_object.diff"
LS0tIG51bWJlcl9vYmplY3QuaAlUaHUgTm92IDIxIDIzOjM1OjMyIDIwMDIN
CisrKyBudW1iZXJfb2JqZWN0LmgJU2F0IEphbiAxMSAxNzowNDo0NCAyMDAz
DQpAQCAtMjksNyArMjksNyBAQA0KIA0KICAgY2xhc3MgTnVtYmVySW5zdGFu
Y2VJbXAgOiBwdWJsaWMgT2JqZWN0SW1wIHsNCiAgIHB1YmxpYzoNCi0gICAg
TnVtYmVySW5zdGFuY2VJbXAoY29uc3QgT2JqZWN0ICZwcm90byk7DQorICAg
IE51bWJlckluc3RhbmNlSW1wKE9iamVjdEltcCAqcHJvdG8pOw0KIA0KICAg
ICB2aXJ0dWFsIGNvbnN0IENsYXNzSW5mbyAqY2xhc3NJbmZvKCkgY29uc3Qg
eyByZXR1cm4gJmluZm87IH0NCiAgICAgc3RhdGljIGNvbnN0IENsYXNzSW5m
byBpbmZvOw0KLS0tIG51bWJlcl9vYmplY3QuY3BwCVNhdCBKYW4gMTEgMTc6
Mzk6NDkgMjAwMw0KKysrIG51bWJlcl9vYmplY3QuY3BwCVNhdCBKYW4gMTEg
MTc6NDA6MTMgMjAwMw0KQEAgLTM2LDcgKzM2LDcgQEANCiANCiBjb25zdCBD
bGFzc0luZm8gTnVtYmVySW5zdGFuY2VJbXA6OmluZm8gPSB7Ik51bWJlciIs
IDAsIDAsIDB9Ow0KIA0KLU51bWJlckluc3RhbmNlSW1wOjpOdW1iZXJJbnN0
YW5jZUltcChjb25zdCBPYmplY3QgJnByb3RvKQ0KK051bWJlckluc3RhbmNl
SW1wOjpOdW1iZXJJbnN0YW5jZUltcChPYmplY3RJbXAgKnByb3RvKQ0KICAg
OiBPYmplY3RJbXAocHJvdG8pDQogew0KIH0NCkBAIC00Nyw3ICs0Nyw3IEBA
DQogTnVtYmVyUHJvdG90eXBlSW1wOjpOdW1iZXJQcm90b3R5cGVJbXAoRXhl
Y1N0YXRlICpleGVjLA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIE9iamVjdFByb3RvdHlwZUltcCAqb2JqUHJvdG8sDQogICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRnVuY3Rpb25Q
cm90b3R5cGVJbXAgKmZ1bmNQcm90bykNCi0gIDogTnVtYmVySW5zdGFuY2VJ
bXAoT2JqZWN0KG9ialByb3RvKSkNCisgIDogTnVtYmVySW5zdGFuY2VJbXAo
b2JqUHJvdG8pDQogew0KICAgVmFsdWUgcHJvdGVjdCh0aGlzKTsNCiAgIHNl
dEludGVybmFsVmFsdWUoTnVtYmVySW1wOjp6ZXJvKCkpOw0KQEAgLTE2Miw3
ICsxNTgsNyBAQA0KIC8vIEVDTUEgMTUuNy4xDQogT2JqZWN0IE51bWJlck9i
amVjdEltcDo6Y29uc3RydWN0KEV4ZWNTdGF0ZSAqZXhlYywgY29uc3QgTGlz
dCAmYXJncykNCiB7DQotICBPYmplY3QgcHJvdG8gPSBleGVjLT5pbnRlcnBy
ZXRlcigpLT5idWlsdGluTnVtYmVyUHJvdG90eXBlKCk7DQorICBPYmplY3RJ
bXAgKnByb3RvID0gZXhlYy0+aW50ZXJwcmV0ZXIoKS0+YnVpbHRpbk51bWJl
clByb3RvdHlwZSgpLmltcCgpOw0KICAgT2JqZWN0IG9iaihuZXcgTnVtYmVy
SW5zdGFuY2VJbXAocHJvdG8pKTsNCiANCiAgIE51bWJlciBuOw0K
---397395163-1972808330-1042761587=:28184--