calcAbsoluteVertical question

[David Hyatt]

I'm in the process of addressing diveintomark.org's issues with Safari. 
  At #3 is an issue with positioning using "bottom".  I noticed you made 
some fixes to calcAbsoluteVertical (as have I), so I merged that 
function in with your trunk.  It looks to me, though, like the 
following line on the current trunk:

if(!style()->bottom().isVariable())
         b = style()->bottom().width(ch) - cb->borderBottom();

should actually be

if(!style()->bottom().isVariable())
         b = style()->bottom().width(ch) + cb->borderBottom();

It seems like you are determining a value for bottom, and that means 
you want to translate up and not down?

My test case is the following URL:

http://users.rraz.net/mc_on_the_rocks/testpage/abs_relbugs.html

dave
(hyatt@apple.com)

On Wednesday, January 8, 2003, at 10:08 PM, David Hyatt wrote:

> D'oh, yes.  I see.  :)
>
> dave
>
> On Wednesday, January 8, 2003, at 09:56 PM, Dirk Mueller wrote:
>
>> On Mit, 08 Jan 2003, David Hyatt wrote:
>>
>>> Can you explain further why it makes no difference?
>>>
>>
>>>>     case ATTR_MARGINWIDTH:
>>>> +        // Marginwidth applies to both left and right margins -dwh
>>>>         addCSSLength(CSS_PROP_MARGIN_RIGHT, attr->value() );
>>>> +        addCSSLength(CSS_PROP_MARGIN_LEFT, attr->value());
>>>>         /* nobreak; */
>>>>     case ATTR_LEFTMARGIN:
>>>>         addCSSLength(CSS_PROP_MARGIN_LEFT, attr->value() );
>>>>         break;
>>
>> there is a "nobreak" here, i.e. this is a "fall through" case. I never
>> understood why C/C++ made the fall through case default, a "nobreak;"
>> keyword would have made more sense. Oh well..
>>
>>
>> -- 
>> Dirk (received 257 mails today)
>> _______________________________________________
>> Khtml-devel@mail.kde.org
>> http://mail.kde.org/mailman/listinfo/khtml-devel
>
> _______________________________________________
> Khtml-devel@mail.kde.org
> http://mail.kde.org/mailman/listinfo/khtml-devel