dwh? :)

[David Hyatt]

I am dwh.  (David W. Hyatt)

Can you explain further why it makes no difference?

Thanks,
dave

On Wednesday, January 8, 2003, at 09:39 PM, Dirk Mueller wrote:

> Hi,
>
> I wasn't able to guess who "dwh" is. He committed this:
>
> diff -bur /home/dirk/src/clean/30/kdelibs/khtml/html/html_baseimpl.cpp
> ./html_baseimpl.cpp
> --- /home/dirk/src/clean/30/kdelibs/khtml/html/html_baseimpl.cpp
> 2002-12-06 04:01:23.000000000 +0100
> +++ ./html_baseimpl.cpp 2002-12-30 08:24:31.000000000 +0100
> @@ -5,6 +5,7 @@
>   *           (C) 1999 Antti Koivisto (koivisto@kde.org)
>   *           (C) 2000 Simon Hausmann (hausmann@kde.org)
>   *           (C) 2001 Dirk Mueller (mueller@kde.org)
> + * Copyright (C) 2002 Apple Computer, Inc.
>   *
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Library General Public
> @@ -84,13 +85,17 @@
>          break;
>      }
>      case ATTR_MARGINWIDTH:
> +        // Marginwidth applies to both left and right margins -dwh
>          addCSSLength(CSS_PROP_MARGIN_RIGHT, attr->value() );
> +        addCSSLength(CSS_PROP_MARGIN_LEFT, attr->value());
>          /* nobreak; */
>      case ATTR_LEFTMARGIN:
>          addCSSLength(CSS_PROP_MARGIN_LEFT, attr->value() );
>          break;
>      case ATTR_MARGINHEIGHT:
> +        // Marginheight applies to both top and bottom margins -dwh
>          addCSSLength(CSS_PROP_MARGIN_BOTTOM, attr->value());
> +        addCSSLength(CSS_PROP_MARGIN_TOP, attr->value());
>          /* nobreak */
>      case ATTR_TOPMARGIN:
>          addCSSLength(CSS_PROP_MARGIN_TOP, attr->value());
>
>
> Not sure what he tried to fix, but this change for sure makes no 
> difference
> ;-)
>
>
> (was interestingly reported as bugreport against KHTML, although it 
> can only
> be found in the Safari sources. Surprising that after such a short time
> people already studied the code in that detail).
>
>
> -- 
> Dirk (received 253 mails today)
> _______________________________________________
> Khtml-devel@mail.kde.org
> http://mail.kde.org/mailman/listinfo/khtml-devel