change list for WebCore/JavaScriptCore version 60

Darin Adler darin@apple.com
Fri, 14 Feb 2003 15:43:00 -0800


>> - added a canHaveChildren method that returns true for RenderContainer
>> and derived classes, false for RenderReplaced, and don't allow any
>> children inside RenderReplaced; fixes probles with render object
>> children for <object> tags that are images
>
> I've a different fix for that, IMHO its the job of the caller to take 
> care
> of that.

Sounds better.

>> khtml/html
>> ----------
>> - added new quirks/strict mode determination based on the latest one 
>> in
>> Mozilla so we match Mozilla's and IE's idea of when to use strict mode
>
> What is the problem with the code in current HEAD (I mailed the patch 
> here
> some time ago) ?

Dave will answer this question.

>> khtml/xml
>> ---------
>> - broke render object creation part of attach functions into
>> createRendererIsNeeded, createRenderer, styleForRenderer, and
>> rendererIsNeeded to reduce the amount of repetitive code in attach
>> functions
>
> Congratulations, you just added 2 additional virtual method calls for
> avoiding about 2-3 lines of code repetition.
>
> I don't think we should merge this. It might be marginally nicer, but 
> it
> sacrifies speed.

I see your point. Maybe we'll roll back; the additional virtual method 
calls do not have any practical effect on speed for us, by the way. We 
do timings on this sort of thing to make sure.

But you guys have a great track record for making code that's simple 
and fast, so I don't want to ignore your design wisdom.

The reason I did this is that I wanted to add the canHaveChildren() 
check, and that had to go into many different attach() functions.

>> - added ways to detect pages that have password fields or are secure
>> forms so we know not to save the values in them
>
> interesting, we have that password-not-caching in HEAD, but we got a 
> lot of
> complains about this.
>
> what is the idea behind skipping the session-state saving of secure 
> forms?
> this means that upon "back" when you mistyped something in your home 
> banking
> you can start from scratch.
>
> the history is transient, when you close the window its gone.

Trey will answer this question.

>> - fixed memory trasher by checking isHTMLElement as well as id when
>> trying to figure out if a node is a particular class
>
> ?? where?

DocumentImpl::recalcStyleSelector

     -- Darin