for safari: variable alias problem

Maciej Stachowiak mjs@apple.com
Tue, 4 Feb 2003 01:17:41 -0800


On Tuesday, February 4, 2003, at 12:43  AM, Dirk Mueller wrote:

> Hi,
>
> khtmllayout violated the variable aliasing rules of C++. appended is 
> the
> diff, you definitely want to merge this.
>
> it changes its API a little bit, you might have to adjust some more 
> parts of
> the code.
>

Hi Dirk,

This is a good fix, and the new code looks cleaner too. I'll go ahead 
and merge this.

Are anonymous unions portable? ("works in gcc" is good enough for us, 
just thought I'd ask though).

Also, would it be good to make the union private or protected, now that 
there are accessors for all the parts of the bitfield?

Regards,

Maciej