fix crash when trying to triple click with generated content to the right

David Faure dfaure at klaralvdalens-datakonsult.se
Fri Dec 12 13:34:10 CET 2003


On Thursday 11 December 2003 06:19, Darin Adler wrote:
> There's a basic problem with trying to express selection with DOM nodes 
> and offsets: You can't express a selection that has a start or end 
> point inside generated content. At some point, we will solve that 
> problem, but for now, here's a patch that fixes a null-deref triple 
> clicking when the line is like this:
> 
>      <STYLE>label:after { content: ":"; }</STYLE>
>      <LABEL>Date Submitted</LABEL>Tuesday, December 09, 2003
> 
> There's probably a better fix than just adding the nil check, but 
> that's what I did for now.

OK - not reproduceable with khtml CVS HEAD, the code has apparently
been rewritten for other reasons (caret mode, I suppose).

-- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions


More information about the Khtml-devel mailing list