anybody mind if I commit my changes?

Dirk Mueller mueller at kde.org
Mon Aug 18 00:48:06 CEST 2003


On Fre, 08 Aug 2003, Leo Savernik wrote:

> KHTML always uses the term "cursor" to specify the mouse cursor. To eliminate 
> opportunities for confusion, I chose the term "caret" whenever I referred to 
> the blinking thingy (as does Mozilla), and I already used it hundreds of 
> times in the navigation code, so I'd like to keep it. However, I can, if you 
> wish, rename caretPos back to cursorPos.

You're right. caretPos is okay with me. 

> I'm okay using ### but I'd rather retain (LS) otherwise I might forget that I 
> put this comment there.

Ok. 

> building up and traversing lines of a paragraph. It's only because of line 
> persistance why I ported it at all. This port of TextSlave/Run is extra-huge 
> because it keeps some members that aren't there any more in Safari.

I hope we can slim this down soon because it looks like a massive overhead 
to me. 

> RootInlineBox. InlineBoxes are the least common denominator for any part of a 
> render object that still fits on the same line (ie a text slave or a replaced 
> element).

huh?

> I ported it over from WebCore as is. I'd like to leave it to keep the diff 
> between the two projects smaller.

Well I hope that the Safari developers are merging such trivial changes in 
their tree as well so it will not make or diverging diff any bigger. 


I'm okay with the patch as soon as we sorted the naming sheme out (see other 
reply to David Hyatt). 


Thanks a lot for this work, Leo. 


-- 
Dirk


More information about the Khtml-devel mailing list