[kgraphviewer-devel] New release of KGraphViewer

Mon Jun 23 07:34:54 UTC 2014

Hi Reimar,

You was right in reverting my change. With yours, I do not encounter this crash again.

It still crashed though when using the recent files action. My last commit avoids this crash but with no good reason. I suspect a memory corruption. When I run through valgrind with my last commit, I get no error.

Gaël

----- Mail original -----
De: "Reimar Döffinger" <Reimar.Doeffinger at gmx.de>
À: kgraphviewer-devel at kde.org
Envoyé: Dimanche 22 Juin 2014 10:49:57
Objet: Re: [kgraphviewer-devel] New release of KGraphViewer

On Fri, Jun 20, 2014 at 09:39:52AM +0200, kleag at free.fr wrote:
> Note that the reload error seems to happen only on graphs with syntax error (warning) like the one attached. They are loaded and displayed well at the first time.

I found and committed a "fix" (more like ugly-as-hell hack) for this issue.
It seems to me cgraph has loads of memory and state leaks
all over the place :(
I took the liberty to revert your crash fix, because it made
things worse for me, if you can still reproduce crashes in some
cases please tell me and I'll try to figure it out.

Reimar

> ----- Mail original -----
> De: kleag at free.fr
> À: "Milian Wolff" <mail at milianw.de>
> Cc: kgraphviewer-devel at kde.org
> Envoyé: Jeudi 19 Juin 2014 23:02:17
> Objet: Re: [kgraphviewer-devel] New release of KGraphViewer
> 
> Hi Milian,
> 
> I just  commited a change making it not to crash but reloading (manually with F5 or automaticaly when touching the graph file) still does not work. I don't understand what happens, probably in cgraph.
> 
> Concerning the absence of kgv from distributions, it is not in my Mageia 4 nor in the Ubuntu I use also at work. And I agree with 
> you Milian, it is  not surprising that some distributions remove it. 
> 
> I cannot take up  the maintainership as I'm not enough available to handle releases, etc. I'm already responsible of large software at work that  we have freed up (aymara/lima) and I cannot take more currently.
> 
> Bye,
> 
> Gaël
> 
> ----- Mail original -----
> De: "Milian Wolff" <mail at milianw.de>
> À: kgraphviewer-devel at kde.org
> Cc: kleag at free.fr
> Envoyé: Jeudi 19 Juin 2014 13:26:4
> Objet: Re: [kgraphviewer-devel] New release of KGraphViewer
> 
> On Thursday 19 June 2014 12:45:27 kleag at free.fr wrote:
> > Hi Milian,
> > 
> > You're perfectly right. I alse wanted to do so since some time. But I have
> > some crashes on my machine (when reloading changed graphs). I should
> > probably try to correct them before. I'll try to have a look to that today.
> > I will send a mail as soon as I'm ready.
> > 
> > Do you agree with that ?
> 
> Yes, sounds good.
> 
> > BTW, I'd like to see kgraphviewer back into distributions...
> 
> Due to the long time it simply did not work at all with the update to 
> GraphViz, I can only understand the distributions to kill KGraphViewer. I'd 
> welcome it if you could take up the maintainer role again and polish 
> KGraphViewer more, and ensure it stays functional. That should ensure it gets 
> packaged.
> 
> There are also some more performance fixes I'll push.
> 
> Bye
> 
> > ----- Mail original -----
> > De: "Milian Wolff" <mail at milianw.de>
> > À: kgraphviewer-devel at kde.org
> > Envoyé: Jeudi 19 Juin 2014 12:32:47
> > Objet: [kgraphviewer-devel] New release of KGraphViewer
> > 
> > Hey all,
> > 
> > are there any objections to creating a new release of KGraphViewer? The
> > fixes in supporting newer GraphViz versions should be made public, I think.
> > 
> > If nothing speaks against that, I'll tag and branch off 2.2 and send it to
> > the packagers. Sounds good?
> > 
> > Bye
> 
> -- 
> Milian Wolff
> mail at milianw.de
> http://milianw.de
> _______________________________________________
> kgraphviewer-devel mailing list
> kgraphviewer-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kgraphviewer-devel

> digraph sentence0 {
>   graph [rankdir=LR,]
>   node [shape=box,]
>   edge []
> 0 [label="0\lno FullToken",fontname="Monospace",fontsize="9"]0 -> 10 [color=darkgray]10 [label="10\lcette\lDET\l163840\l",fontname="Monospace",fontsize="9"]10 -> 9 [color=darkgray];
> 10->9 [color=red,fontcolor=red,weight=0,fontname="Monospace",fontsize="9",label="DETSUB"]9 [label="9\lmaison\lNC\l188416\l",fontname="Monospace",fontsize="9"]9 -> 8 [color=darkgray];
> 9->8 [color=red,fontcolor=red,weight=0,fontname="Monospace",fontsize="9",label="CPL_V"]8 [label="8\lest\lV\l229376\l",fontname="Monospace",fontsize="9"]8 -> 7 [color=darkgray]7 [label="7\lla\lDET\l163840\l",fontname="Monospace",fontsize="9"]7 -> 6 [color=darkgray];
> 7->5 [color=red,fontcolor=red,weight=0,fontname="Monospace",fontsize="9",label="DetAdj"]6 [label="6\lplus\lADV\l147456\l",fontname="Monospace",fontsize="9"]6 -> 5 [color=darkgray];
> 6->5 [color=red,fontcolor=red,weight=0,fontname="Monospace",fontsize="9",label="ADVADJ"]5 [label="5\lbelle\lADJ\l139264\l",fontname="Monospace",fontsize="9"]5 -> 4 [color=darkgray]4 [label="4\ldu\lDETDU\l557056\l",fontname="Monospace",fontsize="9"]4 -> 3 [color=darkgray];
> 4->3 [color=red,fontcolor=red,weight=0,fontname="Monospace",fontsize="9",label="DETSUB"]3 [label="3\lquartier\lNC\l188416\l",fontname="Monospace",fontsize="9"]3 -> 2 [color=darkgray];
> 3->5 [color=red,fontcolor=red,weight=0,fontname="Monospace",fontsize="9",label="COMPADJ"]};
> 

> _______________________________________________
> kgraphviewer-devel mailing list
> kgraphviewer-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kgraphviewer-devel

_______________________________________________
kgraphviewer-devel mailing list
kgraphviewer-devel at kde.org
https://mail.kde.org/mailman/listinfo/kgraphviewer-devel