[kgraphviewer-devel] Review Request: Fix KGraphViewer build with boost-1.50

Michael Palimaka kensington at gentoo.org
Tue Jul 10 15:34:21 UTC 2012



> On July 10, 2012, 3:16 p.m., Milian Wolff wrote:
> > will this also work with older Boost versions? Yes, or? Then this looks fine to me.
> >

Thanks for the quick review.

The change is backwards-compatible with boost 1.36 and up. (I note that this style of include is already present in KGraphViewer, so this does not decrease compatibility.)


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105494/#review15625
-----------------------------------------------------------


On July 9, 2012, 4:31 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105494/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 4:31 p.m.)
> 
> 
> Review request for KGraphViewer.
> 
> 
> Description
> -------
> 
> Build fails because the headers referenced are deprecated "forwarding headers", which have been removed in boost-1.50. This patch simply uses headers from the correct location.
> 
> For reference, note that this was already fixed for src/part/dotgrammar.h
> 
> 
> Diffs
> -----
> 
>   src/part/DotGraphParsingHelper.cpp 69cac49864190df9b79b31b4f2def51b93abf029 
> 
> Diff: http://git.reviewboard.kde.org/r/105494/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kgraphviewer-devel/attachments/20120710/02e024c0/attachment.html>


More information about the kgraphviewer-devel mailing list