[kgraphviewer-devel] Review Request: Fix the missing icons in the setting dialog of kgrapheditor
Milian Wolff
mail at milianw.de
Mon Jul 9 14:15:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105482/#review15570
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On July 8, 2012, 6:42 p.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105482/
> -----------------------------------------------------------
>
> (Updated July 8, 2012, 6:42 p.m.)
>
>
> Review request for KGraphViewer.
>
>
> Description
> -------
>
> I'm just looking at http://techbase.kde.org/Projects/Oxygen/KDE4_Missing_Icons, and I notice that the problem of missing icons is "fixed" in kgraphviewer but not in kgrapheditor. So this patch just repeats the work done in commit 7a72a3eaf649508dbcd60b86ecd9f6b7325bfce5.
>
> I'm not sure commit 7a72a3eaf649508dbcd60b86ecd9f6b7325bfce5 is the right fix, but I think consistency is important.
>
>
> Diffs
> -----
>
> src/kgrapheditorConfigDialog.cpp 7b7ad15
>
> Diff: http://git.reviewboard.kde.org/r/105482/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kgraphviewer-devel/attachments/20120709/1d8ed412/attachment.html>
More information about the kgraphviewer-devel
mailing list