[kgraphviewer-devel] Review Request: Fix syntax error in a .dot file

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102968/#review7616
-----------------------------------------------------------

Ship it!


looks good. please provide the patch as created by "git format-patch" and I'll push it upstream

thanks

- Milian Wolff


On Oct. 25, 2011, 1:58 p.m., Ivan Brezina wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102968/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2011, 1:58 p.m.)
> 
> 
> Review request for KGraphViewer.
> 
> 
> Description
> -------
> 
> An attribute ID is not allowed for subgraph. But graph in subgraph can have it's own ID.
> 
> For example this file has syntax error in it:
> digraph "unnamed" {
> graph [fontsize="11",id="unnamed"]
> subgraph cluster_X1  {id="cluster_X1",label="X1",cluster_X1_T1_1
> [comment="T1",fontsize="10",id="cluster_X1_T1_1",label="T1",name="T1"];
> }
> }
>  
> While this one is correct:
> digraph "unnamed" {
> graph [fontsize="11",id="unnamed"]
> subgraph cluster_X1  {
> graph[id="cluster_X1",label="X1"]
> cluster_X1_T1_1
> [comment="T1",fontsize="10",id="cluster_X1_T1_1",label="T1",name="T1"];
> }
> }
> 
> 
> Diffs
> -----
> 
>   src/part/graphelement.cpp bc409f8 
>   src/part/graphsubgraph.cpp 07bc8db 
> 
> Diff: http://git.reviewboard.kde.org/r/102968/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Brezina
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kgraphviewer-devel/attachments/20111025/9fc4b209/attachment.html>