[kgraphviewer-devel] Syntax error in .dot file (plus big thankyou)

[Milian Wolff]

On Tuesday 11 October 2011 22:50:11 Ivan Brezina wrote:
> Hi all,
> first of all I would like to thank you for all the work you made on
> kgraphviewer.
> I'm about to use a part of it in another GNU project - Tora
> (http://torasql.com/).
> I spent a lot of time looking for some example of integrating graphwiz
> with QT,
> and your project is the best one can find on the Internet.
> 
> Would you mind if I used part of kgraphviewer as generic planar graph
> visualization widget?

As long as you conform to the license, you can do whatever you want with it :)

> Would you accept patches that remove dependency on legacy QT3?

Sounds like work we'd had to do ourselves otherwise. So: go for it!

> BTW: I've found that in some cases kgraphviewer produces .dot files
> whose are not
> syntactically correct. Command dot complains about syntax error but
> processes them anyway.
> 
> For example this file has syntax error in it:
> digraph "unnamed" {
> graph [fontsize="11",id="unnamed"]
> subgraph cluster_X1  {id="cluster_X1",label="X1",cluster_X1_T1_1
> [comment="T1",fontsize="10",id="cluster_X1_T1_1",label="T1",name="T1"];
> }
> }
> 
> While this one is correct:
> digraph "unnamed" {
> graph [fontsize="11",id="unnamed"]
> subgraph cluster_X1  {
> graph[id="cluster_X1",label="X1"]
> cluster_X1_T1_1
> [comment="T1",fontsize="10",id="cluster_X1_T1_1",label="T1",name="T1"];
> }
> }
> 
> This patch adds graph declaration onto subgraph:

<snip>

Sounds fine if it now conforms to the dot syntax push it to the git repo. If 
you don't have permissions for that, please attach the patch as created by 
"git format-patch" and I'll push it for you.

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de