[KGet] [kget] [Bug 347983] New: kget fails to build using qt-5.5

[chrisb2244 at gmail.com]

https://bugs.kde.org/show_bug.cgi?id=347983

            Bug ID: 347983
           Summary: kget fails to build using qt-5.5
           Product: kget
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Core
          Assignee: kget at kde.org
          Reporter: chrisb2244 at gmail.com

kget fails to build using qt-5.5. Apparently this is due to a change in qtcore.
Can be fixed by explicitly including <QDataStream> in core/signature.h
Build error occurs in core/signature.cpp, but inclusion there leads to errors
with the header. Since the header is included in the cpp file, one inclusion is
sufficient for the .h file, but I don't know if the kde style would prefer
explicit inclusion in both files.

Reproducible: Always

Steps to Reproduce:
1. Use qt-5.5 (I have the git sources for my build)
2. Switch to kf5_port in kget
3. Attempt to build kget on the kf5_port branch. 

Actual Results:  
cmake works but make fails with error 

core/signature.cpp:100:5 error: type 'QObject' is not a direct base of
'Signature' : QObject(object)

Expected Results:  
make succeeds.

Fixed by inclusion of <QDataStream>

Will add patch here.

-- 
You are receiving this mail because:
You are the assignee for the bug.