[Kget] [Bug 296867] New: kdenetwork claims that QCA2 is optional, but kget requires it

[Jonathan Marten]

https://bugs.kde.org/show_bug.cgi?id=296867

            Bug ID: 296867
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: kget at kde.org
           Summary: kdenetwork claims that QCA2 is optional, but kget
                    requires it
    Classification: Unclassified
                OS: Linux
          Reporter: jjm at keelhaul.me.uk
          Hardware: Other
            Status: NEW
         Component: general
           Product: kget

The top level CMakeLists.txt for kdenetwork checks for the optional presence of
QCA2:

macro_optional_find_package(QCA2)
macro_log_feature(QCA2_FOUND "QCA2" "Qt Cryptographic Architecture"
"http://delta.affinix.com/qca" FALSE "2.0.0" "Needed for the KGet
bittorrent-plugin and some Kopete plugins")

and indeed does not complain if it is not found:

-----------------------------------------------------------------------------
-- The following OPTIONAL packages could NOT be located on your system.
-- Consider installing them to enable more features from this software.
-----------------------------------------------------------------------------
   * QCA2 (2.0.0 or higher)  <http://delta.affinix.com/qca>
     Qt Cryptographic Architecture
     Needed for the KGet bittorrent-plugin and some Kopete plugins

However, the kget/tests appears to unconditionally require QCA2:

#===========Verifier===========
kde4_add_unit_test(verifiertest
  TESTNAME kget-verifiertest
  verifiertest.cpp
)
target_link_libraries(verifiertest ${QT_QTTEST_LIBRARY} ${KDE4_KDECORE_LIBS}
${QCA2_LIBRARIES} kgetcore)

and the configuration fails if QCA2 is not available:

CMake Error: The following variables are used in this project, but they are set
to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake
files:
QCA2_LIBRARIES (ADVANCED)
    linked by target "verifiertest" in directory
/ws/trunk/kdenetwork/kget/tests
-- Configuring incomplete, errors occurred!

The optional/required status should be consistent between kdenetwork and kget.

-- 
You are receiving this mail because:
You are the assignee for the bug.