[Kget] [PATCH] Only Display Network Status Notifications When Needed

[Lukas Appelhans]

Looks good to me, but those bools should be "const bool" :)

I didn't test it yet, but it makes sense to me :)

Matthias, any complaints?

Lukas

Am Montag, 26. März 2012, 05:37:55 schrieb David Narvaez:
> Hi,
> 
> The following patch suppresses notifications of transfers
> resumed/stopped on network status changes when nothing was
> resumed/stopped. This is, from my POV, a little usability improvement
> since every time I see a notification that transfers are resumed when
> I'm not downloading anything, I wonder if there are actually any
> transfers going on in KGet which I don't know about.
> 
> Steps to test (on wifi):
> 
> 1) Start a large download
> 2) Use Plasma Network Applet to disconnect from wifi, you should see a
> notification that transfers were stopped
> 3) Use Plasma Network Appleto to connect back to wifi, you should see
> a notification that transfers were resumed
> 4) Pause the download
> 5) Repeat step 2, you should not see a notification that transfers were
> stopped 6) Repeat step 3, no notification should show up
> 
> David E. Narvaez
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kget/attachments/20120326/00680005/attachment.sig>