[Kget] KDE/kdenetwork/kget/transfer-plugins/mmsthreads

Raphael Kubo da Costa rakuco at FreeBSD.org
Wed Aug 31 17:15:33 UTC 2011


SVN commit 1250606 by rkcosta:

Do not link directly to libmms and add its include path.

Hardcoding libmms in target_link_libraries() means the values found by CMake
will not be used, and thus the linker will add just -lmms instead of
-l/full/path/to/libmms.so (so compilation fails if libmms is in a non-standard
path).

libmms' include path is added due to the same reason (the includes will fail if
libmms is in a non-standard location).

CCMAIL: kget at kde.org


 M  +2 -1      CMakeLists.txt  


--- trunk/KDE/kdenetwork/kget/transfer-plugins/mmsthreads/CMakeLists.txt #1250605:1250606
@@ -1,5 +1,6 @@
 include_directories(
    ../../
+   ${LIBMMS_INCLUDE_DIR}
 )
 
 set(kget_mmsfactory_PART_SRCS
@@ -12,7 +13,7 @@
 kde4_add_kcfg_files(kget_mmsfactory_PART_SRCS mmssettings.kcfgc)
 kde4_add_plugin(kget_mmsfactory ${kget_mmsfactory_PART_SRCS})
 
-target_link_libraries(kget_mmsfactory ${KDE4_KIO_LIBS} kgetcore mms)
+target_link_libraries(kget_mmsfactory ${KDE4_KIO_LIBS} kgetcore ${LIBMMS_LIBRARIES})
 
 install(TARGETS kget_mmsfactory DESTINATION ${PLUGIN_INSTALL_DIR})
 install(FILES kget_mmsfactory.desktop DESTINATION ${SERVICES_INSTALL_DIR})


More information about the Kget mailing list