[Kget] [Bug 208373] New: i18n bug trunk + branch: catalog not loaded, wrong use of I18N_NOOP

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=208373

           Summary: i18n bug trunk + branch: catalog not loaded, wrong use
                    of I18N_NOOP
           Product: kget
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: plasma widget
        AssignedTo: kget at kde.org
        ReportedBy: lueck at hube-lueck.de


Version:            (using Devel)
Installed from:    Compiled sources

the kget plasmoids and datengine are buggy i18n wise, since 2 years. That's 
incredible.

kgetengine.cpp has these lines:

setData(I18N_NOOP(name), I18N_NOOP("error"), false);
setData(I18N_NOOP(name), I18N_NOOP("transfers"),
                                                
kget_interface.transfers().value());
setData(I18N_NOOP(name), I18N_NOOP("error"), true);
setData(I18N_NOOP(name), I18N_NOOP("errorMessage"), 
                                        I18N_NOOP("Is KGet up and running?"));
setData(I18N_NOOP("KGet"), I18N_NOOP("error"), false);
setData(I18N_NOOP("KGet"), I18N_NOOP("transfers"), transfers);

api says setData (source, key, value)

The I18N_NOOP do nothing but mark the messages only for extraction, this does 
not return a translation.

And to be honest, do you realy want a translated source and key in these 
calls? I'm sure that will not work.

the only place where you need an i18n here is the string  "Is KGet up 
and running?", which I see untranslated in the GUI cause of the wrong 
I18N_NOOP, which has to be changed to i18n().

the patch solves this issue, any objection to commit?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.