[Kget] KGet Runner

[Tomas Van Verrewegen]

No prob.


1.

I figured it out in the meantime :)

I also checked "test_transfers.cpp". Here "KRun::runCommand(...)" is used to 
start KGet if it isn't already running.

DBus offers the same functionality (see http://dbus.freedesktop.org/doc/dbus-
specification.html#message-bus-starting-services ).

The code I'm using now is far from perfect, but I've been doing some more 
research on DBus and will clean this up a bit in the next couple of days, 
cause the way I'm doing it now is not very clean and there are better options.

The "org.kde.kget.service" tells DBus that KGet can be automatically started, 
so even if it isn't used in KGet internally, it's nice to provide the option 
of starting KGet via DBus.


2.

That's what I thought, but not what happens.... (at least not with  
KGet-2.3.1/KDE-4.3.1, might have changed in trunk).

Can you verify these scenarios:

(A) 3 x the same URL:
- in krunner, type: "http://a"
- choose "download with kget"
- leave the dialog open
- in krunner, type: "http://a"
- choose "download with kget"
-> now the dialog contains "http://a" twice
- leave the dialog open
- again in krunner, type: "http://a"
- choose "download with kget"
-> now the dialog contains "http://a" once again

(B) 3 different URLs:
- in krunner, type: "http://a"
- choose "download with kget"
- leave the dialog open
- in krunner, type: "http://b"
- choose "download with kget"
-> now the dialog contains "http://a" and "http://b"
- leave the dialog open
- again in krunner, type: "http://c"
- choose "download with kget"
-> now the dialog contains only "http://c"


Yours, Tomas


On Thursday 01 October 2009 14:03:37 Lukas Appelhans wrote:
> Sorry, I got some surgery on tuesday, so I wasn't able to respond more
> quickly...
> 
> 1) I have not much of a clue, but do we really need that file?
> 
> Anyway: we call kget-dbus as well from kget_test_transfers app, so maybe
>  check how we do it there... :)
> 
> 2) yeah the newtransferdialog should always add urls if the method gets
>  called and it is still open...
> 
> Lukas
> 
> Am Dienstag 29 September 2009 10:42:56 schrieb Tomas Van Verrewegen:
> > Ok. Got my SVN account details, so I committed this.
> >
> >
> > 2 comments:
> >
> > 1. org.kde.kget.service needs to be added to "kdenetwork/kget/desktop".
> > But I don't really know how to tell cmake to put the correct install
> > prefix in the entry: "Exec=/usr/bin/kget".... Anyone?
> >
> > 2. Because "showNewTransferDialog()" blocks, krunner became unresponsive
> > as long as the "New Download" dialog was open. I switched the DBus code
> > to an "asyncCall" to work around this.
> > But....
> > I stumbeled on some weirdness in the showNewTransferDialog()
> >  implementation: Reproduce like this (using runner from svn):
> > - in krunner, type: "http://a"
> > - choose "download with kget"
> > - leave the dialog open
> > - again in krunner, type: "http://a"
> > - choose "download with kget"
> > -> now the dialog contains "http://a" twice
> > - leave the dialog open
> > - again in krunner, type: "http://a"
> > - choose "download with kget"
> > -> now the dialog contains "http://a" once again
> >
> > This behaviour only occurs when the URL's you enter are identical.
> > I haven't found the time yet to investigate this further.
> > If you like, I can put this in a bug report...
> >
> >
> >
> > Cheers, Tomas
> > _______________________________________________
> > Kget mailing list
> > Kget at kde.org
> > https://mail.kde.org/mailman/listinfo/kget
> 
> _______________________________________________
> Kget mailing list
> Kget at kde.org
> https://mail.kde.org/mailman/listinfo/kget
>