[Kget] KDE/kdenetwork/kget/core

[Lukas Appelhans]

Am Donnerstag 23 Juli 2009 11:56:38 schrieb Carsten Pfeiffer:
> SVN commit 1001436 by pfeiffer:
>
> BUG: 170496
> forward port from 4.3 branch: do not save finished transfers in the
> transfers.kgt file at all
Sorry, but this commit is bullshit! It changes the whole behaviour of finished 
transfers at all... it should have been DISCUSSED! (as well as some other 
commits I think...)

Sorry, that I was away for 3 weeks, but now I'm back! I know there are some 
issues which must be adressed in KGet, but we don't want to fall back to a 
KDE3-like-KGet, sorry! I don't think this is the way we should go...

Regards,

Lukas
>
>
>  M  +6 -2      transfergroup.cpp
>
>
> --- trunk/KDE/kdenetwork/kget/core/transfergroup.cpp #1001435:1001436
> @@ -354,10 +354,14 @@
>
>      for( ; it!=itEnd; ++it )
>      {
> -        kDebug(5001) << "  -->  " << name() << "  transfer: " <<
> ((Transfer *) *it)->source(); +        Transfer* transfer =
> static_cast<Transfer*>(*it);
> +        if (transfer->status() != Job::Finished) // do not save finished
> downloads +        {
> +            kDebug(5001) << "  -->  " << name() << "  transfer: " <<
> transfer->source(); QDomElement t =
> e.ownerDocument().createElement("Transfer"); e.appendChild(t);
> -        ((Transfer *) *it)->save(t);
> +            transfer->save(t);
> +        }
>      }
>  }