[Kget] [Bug 131712] KGet overwrites data when trying to rename file from *.part to *

[Olli Salonen]

http://bugs.kde.org/show_bug.cgi?id=131712


Olli Salonen oasalonen gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oasalonen at gmail.com




--- Comment #2 from Olli Salonen <oasalonen gmail com>  2009-01-12 18:17:18 ---
I'm using KDE4 trunk sources, so the code is probably different than when this
bug was reported. For example, no error is given when the directory permissions
are changed to 666.

When directory permissions are changed during the download and the download is
finished, the .part file is not renamed and the KJob finishes. It calls
TransferKio::slotResult() with no error code (0). kget assumes the download is
fine and reports it as finished.

If the directory permissions are reverted afterwards, clicking Start/Resume
will not rename the .part file because kget considers the download finished.
Perhaps an additional check should be made when the Start/Resume is clicked for
the existence of the .part file? It cannot be done during the call of
TransferKio::slotResult() because directory permissions would not allow
examining the directory contents. Or in this case, kget could assume the
renaming did not succeed if right after finishing the download the directory
has no exec permissions.

Any thoughts from the kget devs?


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.