[Kget] GSOC -- Review

[Lukas Appelhans]

Hey!

I had a look over the code today which resulted in a bunch of issues I'd like 
to talk to you (on IRC). We'll meet there at some time I guess so we can 
discuss those... :)

But at all it's really awesome work you've done! :)

Lukas

Am Samstag 15 August 2009 17:02:34 schrieb Matthias Fuchs:
> Hi,
>
> My name is Matthias Fuchs and I'm the GSOC-student who worked on KGet (just
> to be sure that you know who I am :) ). Now that GSOC is close to its end
> it would be fantastic if you could review my code.
>
> So turn your "-pedantic"-mode on and look for errors, design mistakes,
> coding style stuff etc. that way the code should be hopefully in a real
> good state once it enters trunk.
>
>
> You can get the code here [1] or simply follow the instruction (copied from
> a mail I sent to Urs Wolfer):
>
> git clone git://github.com/mfuchs/kget-gsoc.git && cd kget-gsoc
> git checkout -b GSOC/master && git pull origin GSOC/master
>
> now to get a diff you could type
> git diff master > fullDiff.diff
>
> to update type, you should do that from while to while, to see if I
> commited changes to github:
> git pull origin GSOC/master
>
> to see all commits type:
> gitk
> that way you could also look at only the last commits.
>
>
> What is the structure of my repo?
> I tried to have as few commits as possible, so I put together what belongs
> together, that does not mean though that each commit would compile on its
> own. Additionally the commits with upper letters like "METALINKCREATOR:
> ..." mean that they are only temporary (to avoid rebasing --> that would be
> a pain for you if you update), as soon as I commit all that to trunk they
> will be merged with the correct commits, in this case with the one that
> initially adds the MetalinkCreator.
>
>
> I hope you understood my ramblings, please add comments, flamings or
> whatever you please. :)
>
> Cheers!
> matthias
>
> [1] http://github.com/mfuchs/kget-gsoc/tree/GSOC/master
>
>
> PS.: Yes, I plan to stick to KGet-Developement, so your comments would not
> be useless. ;)
> _______________________________________________
> Kget mailing list
> Kget at kde.org
> https://mail.kde.org/mailman/listinfo/kget