[Kget] R: KDE/kdenetwork/kget

[nekkar at libero.it]

Ehi Carsten! What was the reason for commenting out these two lines? Seems like 
without them kget crashes in 4.3 release (see https://bugs.kde.org/show_bug.cgi?
id=202778)..

+/*
         menuActions.setItemListProperties
(KFileItemListProperties(items));
         menuActions.setParentWidget(parent);

+*/

AFAIK this is because the KFileItemActions::addServiceActionsTo(QMenu* 
mainMenu)    function doesn't handle empty ItemListProperties.. 
What do you 
think?

Dario

>----Messaggio originale----
>Da: pfeiffer at kde.org
>Data: 
22/07/2009 11.10
>A: <kde-commits at kde.org>
>Ogg: KDE/kdenetwork/kget
>
>SVN 
commit 1000869 by pfeiffer:
>
>BUG: 188673
>forward port from 4.3 branch:

>always show the filedialog as it was in KDE 3.x, instead of
>the new-transfer-
dialog
>
>
>
> M  +2 -2      main.cpp  
> M  +2 -0      ui/contextmenu.cpp  
>

>
>--- trunk/KDE/kdenetwork/kget/main.cpp #1000868:1000869
>@@ -116,9 +116,9 @@

>         }
>         // all the args read from command line are downloads

>         if (l.count() == 1)
>-            NewTransferDialog::instance(kget)-
>showDialog(l.takeFirst().url());
>+            KGet::addTransfer(l.
takeFirst());
>         if (l.count() > 1 && !l.last().isLocalFile())

>-            NewTransferDialog::instance(kget)->showDialog(l);
>+            
KGet::addTransfer(l);
>         return 0;
>     }
> 
>--- 
trunk/KDE/kdenetwork/kget/ui/contextmenu.cpp #1000868:1000869
>@@ -101,8 +101,
10 @@
>         items << KFileItem(KFileItem::Unknown, KFileItem::Unknown, 
handler->dest());
> 
>         KonqMenuActions menuActions;
>+/*
>         
menuActions.setItemListProperties(KFileItemListProperties(items));
>         
menuActions.setParentWidget(parent);
>+*/
> 
>         menuActions.addActionsTo
(popup);
>         menuActions.addOpenWithActionsTo(popup, "DesktopEntryName != 
'kget'");
>