[Kget] [PATCH][BUG 184127] Kget closes automatically when a download is marked as finished in the list

[Lukas Appelhans]

On Mittwoch 15 April 2009 04:14:30 Nikhil Marathe wrote:
> Hi,
>
> https://bugs.kde.org/show_bug.cgi?id=184127
>
> This is a fix for when KGet closes as soon as it starts up because all
> downloads are finished. I have added another member m_startState to
> Job which keeps track of what State it was in when the job was first
> created. All finished downloads then stay in the same state, while new
> downloads move from Stopped to Finished.
> GenericTransferObserver::allTransfersFinished() has been changed to
> reflect appropriate logic ( which is a bit convoluted ). Hopefully my
> path of fixing won't be architecturally bad.
>
> The patch should be applied in kdenetwork/kget
>
> Cheers
> Nikhil
Hey!
The patch looks fine to me overall, although the first setStartStatus() should 
be IN the else-clause, the if-clause has load(*e); in it so doesn't need it... 
(no need to set it twice when creating a transfer not from e... :)

Also we should clean up allTransfersFinished() to use only one bool... :)

Lukas