[Kget] Fwd: Re: [PATCH] New Drop-Target-Download-Dialog

[Javier Goday]

What if you declare the method this way in the class NewTransferDialog:

static void showNewTransferDialog(QString url=QString());

this way we don't need to change anything in the existing code (Ej.
the slotNewTransfer in the MainWindow)

maybe you should follow the current codestyle guidelines (the HACKING
file in kget) ;)
i have to pay more attention to this guidelines too :)


On 10/1/07, Lukas Appelhans <l.appelhans at gmx.de> wrote:
>
> ----------  Weitergeleitete Nachricht  ----------
>
> Betreff: Re: [Kget] [PATCH] New Drop-Target-Download-Dialog
> Datum: Montag, 1. Oktober 2007
> Von: Lukas Appelhans <l.appelhans at gmx.de>
> An: Javier Goday <jgoday at enmacosa.com>, kget at kget.org
>
> Am Montag, 1. Oktober 2007 10:15:46 schrieben Sie:
> > On Monday 01 October 2007 01:26:34 Lukas Appelhans wrote:
> > > Hi!
> > > I wrote a patch to make the Drop-Traget-Download-Dialog like the one,
> > > when you click on "New Download"-Button. There's now the "Set as default
> > > folder"-Option, too, of course.
> > > So, hope you enjoy it and post comments please :-D
> >
> > Awesome man, great !
> Thx
> >
> > would be great if you can merge the two methods in NewTransferDialog class
> >      static void showNewTransferDialog();
> >      static void showNewTransferDialog(QString url);
> >
> > in only one with a default parameter QString url = "" or something, this
> > way avoid  duplicate code
> Yeah, we can make sth like
> if(url.isEmpty())
> url=<Clipboard>
>
> So, I posted a patch as an attachment, this should works fine...
>
> >
> > > PS: Perhaps the dialog when you use "Save Link As" in Konqueror should
> > > look like this, too, but don't know, I think it would not be a big
> > > problem to change it
> >
> > I think you are right, this would be great !
> > And maybe this could fix a problem from
> >  KHTMLPopupGUIClient class, wich is used by the konqueror to show the
> 'Save
> > as Link' (i think), and already ask the user for a destination folder,
> > calls to kget this way 'kget source destination'
> > and kget can't recognize the destination folder this way, asking again to
> > the user !
>
> Ok, I will look at this... :-)
>
>
> Cheers boom1992
>
>
>
>
>
> -------------------------------------------------------
>
> PS: Don't know this is the second time I send the mail, b/c it was not
> listed
> @ lists.kde.org and I didn't become a mail back :-(
>