[Kget] [PATCH] New Drop-Target-Download-Dialog

Javier Goday jgoday at enmacosa.com
Mon Oct 1 10:15:46 CEST 2007


On Monday 01 October 2007 01:26:34 Lukas Appelhans wrote:
> Hi!
> I wrote a patch to make the Drop-Traget-Download-Dialog like the one, when
> you click on "New Download"-Button. There's now the "Set as default
> folder"-Option, too, of course.
> So, hope you enjoy it and post comments please :-D

Awesome man, great !

would be great if you can merge the two methods in NewTransferDialog class
     static void showNewTransferDialog();
     static void showNewTransferDialog(QString url);

in only one with a default parameter QString url = "" or something, this way 
avoid  duplicate code

> PS: Perhaps the dialog when you use "Save Link As" in Konqueror should look 
> like this, too, but don't know, I think it would not be a big problem to 
> change it

I think you are right, this would be great !
And maybe this could fix a problem from 
 KHTMLPopupGUIClient class, wich is used by the konqueror to show the 'Save as 
Link' (i think), and already ask the user for a destination folder,
calls to kget this way 'kget source destination' 
and kget can't recognize the destination folder this way, asking again to the 
user !






More information about the Kget mailing list