[frameworks-kio] [Bug 451050] Dolphin crashing when connecting SMB share

[Akseli Lahtinen]

https://bugs.kde.org/show_bug.cgi?id=451050

Akseli Lahtinen <akselmo at akselmo.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/-/commit/883a16e
                   |                            |b4ac808deceddf8ac3667ee888f
                   |                            |f8ea60
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #89 from Akseli Lahtinen <akselmo at akselmo.dev> ---
Git commit 883a16eb4ac808deceddf8ac3667ee888ff8ea60 by Akseli Lahtinen.
Committed on 26/06/2025 at 09:38.
Pushed by akselmo into branch 'master'.

KCoreDirLister: Clean up the trailing slash as expected on remote systems

Due to QTBUG-35921 we sometimes get a trailing slash even if we expect
it to be removed.
This patch adds a method that makes sure the trailing slash is
completely removed from the URL
and returns the cleaned URL, but only if the file is in remote directoy.

The code was built around the behavior of the trailing
slash always being removed, so it was comparing URLs:
Even if the URLs point to same location, `smb://aaa` and `smb://aaa/`,
the URLs are considered as different ones.

On remote systems we do not know if the file system allows `foo/bar` and
`foo/bar/` to be the exact same or not. On local systems we can rely on
Qt.

This fixes bug that would cause situations where the job is reusing
itself for the two "different" URLs (from the point of view of the code)
and asserting, as every different URL should have a new job.

M  +42   -28   src/core/kcoredirlister.cpp
M  +10   -0    src/core/kcoredirlister_p.h

https://invent.kde.org/frameworks/kio/-/commit/883a16eb4ac808deceddf8ac3667ee888ff8ea60

-- 
You are receiving this mail because:
You are on the CC list for the bug.