[dolphin] [Bug 422951] Type-ahead navigation in dolphin resets position mid-search when a file is selected

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=422951

fanzhuyifan at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/b4dedc0
                   |                            |d0df2c8b191192476d778763018
                   |                            |0e51c7

--- Comment #11 from fanzhuyifan at gmail.com ---
Git commit b4dedc0d0df2c8b191192476d7787630180e51c7 by Yifan Zhu.
Committed on 22/02/2025 at 22:26.
Pushed by fanzhuyifan into branch 'master'.

kitemlistkeyboardsearchmanager: smarter search start position

Search from the next position for new search and special repeated key search.
Otherwise search from the current position, which is current selected item if
something is selected or in selection mode, and 0 (the beginning) otherwise.

Test plan:
- create directory with files ab1, ab2, and ab3
- click ab2, and press escape to deselect
- type ab; verify that ab1 is selected
- wait a while, type ab again, verify that ab2 is selected
- wait a while, type ab again, verify that ab3 is selected
- click ab1, type ab, verify that ab2 is selected

M  +3    -3    src/kitemviews/kitemlistcontroller.cpp
M  +2    -8    src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp
M  +0    -1    src/kitemviews/private/kitemlistkeyboardsearchmanager.h
M  +452  -116  src/tests/kitemlistcontrollertest.cpp
M  +5    -5    src/tests/kitemlistkeyboardsearchmanagertest.cpp

https://invent.kde.org/system/dolphin/-/commit/b4dedc0d0df2c8b191192476d7787630180e51c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.