[dolphin] [Bug 495878] Customizing the default view settings doesn't work anymore

[Iyán M. V.]

https://bugs.kde.org/show_bug.cgi?id=495878

--- Comment #78 from Iyán M. V. <me at iyanmv.com> ---
(In reply to Méven Car from comment #77)
> (In reply to Iyán M. V. from comment #73)
> > On thing I can't understand is why the commit from Akseli triggers the bug
> > (which I think it was introduced before). Maybe that I can answer after a
> > second round checking the source code...
> 
> Before the default settings set by the user was ignored and so the defaults
> settings were the hardcoded ones matching the condition for  item->isDefault
> in save().
> Fixing this bug exposed the next one.
> This happens commonly in software bug fixing.

Thanks :)

(In reply to Méven Car from comment #76)
> (In reply to Méven from comment #75)
> > Git commit c12946ee2ec8dbbb8645ca5763584574458a0a6c by Méven Car.
> > Committed on 08/02/2025 at 08:43.
> > Pushed by meven into branch 'master'.
> > 
> > Viewproperties: prevent loosing view settings
> > 
> > When they match the hardcoded internal settings, when they should be
> > kept as long as they don't match the currently set default
> > viewproperties.
> > 
> > Is saved in metadata the diff with the hardcoded internal defaults
> > still. A stable default reference allows to change defaults without
> > changing existing saved viewproperties.
> > 
> > M  +64   -0    src/tests/viewpropertiestest.cpp
> > M  +21   -3    src/views/viewproperties.cpp
> > 
> > https://invent.kde.org/system/dolphin/-/commit/
> > c12946ee2ec8dbbb8645ca5763584574458a0a6c
> 
> Iyán M. V. since you were testing with master, can you give master a try
> again and share the result.

Yes, master works as expected for me now. Attributes are not deleted in the
case of Icons + Previews on. Issue is fixed for me. One comment though, maybe
this is the intended behavior but I'm not sure. What gets saved to the
attributes are still the differences with respect the default Dolphin settings,
not the global settings. For example, what I get now, after these last patches
is:

$ getfattr -d ~/Pictures/Wallpapers                                            
                                                                               
                                                141 ↵
# file: home/iyan/Pictures/Wallpapers
user.kde.fm.viewproperties#1="[Dolphin]\012Timestamp=2025,2,8,15,10,9.724\012Version=4\012"

I'm fine with this, but just letting you know, in case this is not the desired
behavior.

-- 
You are receiving this mail because:
You are on the CC list for the bug.