[dolphin] [Bug 481561] No error message when renaming fails

[Jin Liu]

https://bugs.kde.org/show_bug.cgi?id=481561

Jin Liu <m.liu.jin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/-/commit/c5238c9 |em/dolphin/-/commit/829e0eb
                   |946805c8aef69f4b52689ba5a70 |912a5681d5c6fddfd461165ae9f
                   |0c913e                      |5cb093

--- Comment #6 from Jin Liu <m.liu.jin at gmail.com> ---
Git commit 829e0eb912a5681d5c6fddfd461165ae9f5cb093 by Jin Liu.
Committed on 12/10/2024 at 13:17.
Pushed by meven into branch 'master'.

KFileItemModel: fix `setData` in the renaming usage

The `setData` function is used by inline renaming to
update the `text` role (i.e. file name) in the model
before actually do the renaming.

However, the current implementation only updates `text`
and url in KFileItem in this case, leaving the `url` role
and the `m_items` cache untouched. This makes the cache
incoherent, so `index()` won't find the renamed item. It
also makes the `url` role incoherent with the `text` role.

This also fixes the problem mentioned in bug #481561
where when inline renaming fails, it still shows the new
name. (Because `m_model->index` fails to find the new name
and rename it back on job failure.)

M  +8    -1    src/kitemviews/kfileitemmodel.cpp

https://invent.kde.org/system/dolphin/-/commit/829e0eb912a5681d5c6fddfd461165ae9f5cb093

-- 
You are receiving this mail because:
You are on the CC list for the bug.