[dolphin] [Bug 421869] Natural sorting does not sort shorter filename first when another one have underscore

[Carl Schwan]

https://bugs.kde.org/show_bug.cgi?id=421869

Carl Schwan <carl at carlschwan.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/-/commit/e4cc6e6 |em/dolphin/-/commit/06f46b9
                   |9430049366434e3383b1d2ef283 |7a018133a9b9851c61c0e00622c
                   |ed22cc                      |6addb3

--- Comment #3 from Carl Schwan <carl at carlschwan.eu> ---
Git commit 06f46b97a018133a9b9851c61c0e00622c6addb3 by Carl Schwan.
Committed on 25/11/2024 at 12:09.
Pushed by carlschwan into branch 'release/24.12'.

natural sort: exclude extension when comparing filenames

Currently natural sort compares the entire filenames
(basename.extension) when sorting. This causes eg.
"a 2.txt" to appear before "a.txt" when sorted by ascending.
This is unintuitive since people prioritize basenames more
than file extensions.

Instead, change natural sort to compare by basename only and
fallback to comparing extensions if basenames were equal.
This change causes "a.txt" to appear before "a 2.txt" and
matches how other platforms such as GNOME and Windows behave.
Related: bug 416025, bug 470538, bug 312027


(cherry picked from commit e4cc6e69430049366434e3383b1d2ef283ed22cc)

23a12f69 natural sort: exclude extension when comparing filenames
9d2d518b natural sort: refactors based on review
46695e10 natural sort: add testcase to compare against alphabetical sort

Co-authored-by: Eren Karakas <erenkarakas202 at hotmail.com>

M  +18   -1    src/kitemviews/kfileitemmodel.cpp
M  +8    -2    src/kitemviews/kfileitemmodel.h
M  +78   -0    src/tests/kfileitemmodeltest.cpp

https://invent.kde.org/system/dolphin/-/commit/06f46b97a018133a9b9851c61c0e00622c6addb3

-- 
You are receiving this mail because:
You are on the CC list for the bug.