[dolphin] [Bug 492741] Dolphin crashes when opening Properties and Dolphin settings simultanously

[Akseli Lahtinen]

https://bugs.kde.org/show_bug.cgi?id=492741

Akseli Lahtinen <akselmo at akselmo.dev> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/4f0bb80
                   |                            |5d2c3dfdfc87c5000a6a3675da1
                   |                            |d8b6c2
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Akseli Lahtinen <akselmo at akselmo.dev> ---
Git commit 4f0bb805d2c3dfdfc87c5000a6a3675da1d8b6c2 by Akseli Lahtinen.
Committed on 13/11/2024 at 09:42.
Pushed by akselmo into branch 'master'.

generalviewsettingspage: Use qobject_cast instead of static_cast

In generalViewSettingsPage, ActiveWindow is not necessarily a
mainWindow, which can cause dolphin to crash. For example when user
opens folder properties and then dolphin settings, this part thinks
the folder settings is mainWindow.

Instead of static_cast, use qobject_cast, since it will return nullptr
if the DolphinMainWindow is not found.

M  +2    -1    src/settings/viewmodes/generalviewsettingspage.cpp

https://invent.kde.org/system/dolphin/-/commit/4f0bb805d2c3dfdfc87c5000a6a3675da1d8b6c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.