[dolphin] [Bug 424723] When going back or up, underline the folder you just came from instead of selecting it

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=424723

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/122fee5
                   |                            |625f0285ec4ebda79162c723909
                   |                            |89eb2a
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Felix Ernst <felixernst at kde.org> ---
Git commit 122fee5625f0285ec4ebda79162c72390989eb2a by Felix Ernst.
Committed on 18/05/2024 at 22:18.
Pushed by felixernst into branch 'master'.

Avoid implicitly selecting items

Items should only be selected if the user wants to act on them.
However, previous to this commit we sometimes selected items even
when there is no reason to assume that the user would like to act
on them. Such selections are dangerous because they make it more
likely that the user manipulates items by accident which they
never even explicitly selected.

Example: The "Up" action is used to navigate to the parent folder.
This will implicitly select the folder one emerged from after
opening the parent folder, so just one accidental press of the
Delete key will lead to data loss if the press goes unnoticed. This
scenario would have been avoided if no folder had been selected
automatically.

The above example becomes even more dangerous if the user is acting
with elevated privileges.

The following implicit selections of items are being removed:
- Selecting items that are being activated
- Selecting folders one emerges from

Even though these items will no longer be selected after these
actions, they will still be marked as current.

The only downside I see is that our indication of which item is "current" is a
lot weaker than the selection highlight, so it might be more difficult to spot
which folder one has emerged from. However, this could be counter-acted with
some other temporary indication if this really turns out to be a problem.

The only downside I see is that our indication of which item is
"current" is a lot weaker than the selection highlight, so it might be
more difficult to spot which folder one has emerged from. However, this
could be counter-acted with some other temporary indication if this
really turns out to be a problem.

M  +2    -1    src/dolphinviewcontainer.cpp
M  +17   -4    src/kitemviews/kitemlistcontroller.cpp
M  +43   -4    src/tests/dolphinmainwindowtest.cpp
M  +7    -0    src/tests/kitemlistcontrollertest.cpp

https://invent.kde.org/system/dolphin/-/commit/122fee5625f0285ec4ebda79162c72390989eb2a

-- 
You are receiving this mail because:
You are on the CC list for the bug.