[kwin] [Bug 482142] drag in drop files in Google Chrome renders Chrome unusable

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=482142

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/kwin/-/commit/711c5bb43f
                   |                            |2823766d5189dc8d567c8f4cec2
                   |                            |53c
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #46 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 711c5bb43f2823766d5189dc8d567c8f4cec253c by David Edmundson.
Committed on 16/05/2024 at 08:23.
Pushed by davidedmundson into branch 'master'.

wayland: send dndFinished to source if target fails to do so

After receiving a drop a client should call data_offer.finish
to tell the source it's done using the drop.

A client could delete an offer after drop before calling finish.

This can happen with misbehaving/buggy or malicious Wayland clients.
A real case was found in the wild with Chromium, as described in the
linked bug.

In this situation we should let the source know the dnd is finished
as there are no other transfers than can take place.

We don't want to universally send this in all data offer destructors
only, offers that are deleted post drop so the flag on the source is
exposed.

M  +22   -2    src/wayland/abstract_data_source.h
M  +8    -1    src/wayland/dataoffer.cpp
M  +3    -12   src/wayland/datasource.cpp
M  +0    -3    src/wayland/datasource.h

https://invent.kde.org/plasma/kwin/-/commit/711c5bb43f2823766d5189dc8d567c8f4cec253c

-- 
You are receiving this mail because:
You are on the CC list for the bug.