[frameworks-kio] [Bug 475235] [Data loss] Moving files to trash might silently delete them instead

[Pedro V]

https://bugs.kde.org/show_bug.cgi?id=475235

Pedro V <voidpointertonull+bugskdeorg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |CONFIRMED
     Ever confirmed|0                           |1
            Product|dolphin                     |frameworks-kio
          Component|general                     |Trash
                 CC|                            |kdelibs-bugs at kde.org
           Assignee|dolphin-bugs-null at kde.org   |kio-bugs-null at kde.org
            Version|23.08.1                     |unspecified

--- Comment #3 from Pedro V <voidpointertonull+bugskdeorg at gmail.com> ---
Recommending using the "Permalink" button when linking source code files as the
links containing "master" will just point to whatever is the latest, so they
will become stale over time as files are changed and lines are drifting around
if not completely changed or removed.

Looking at the code, the key will be the "Configure Dolphin to skip the
confirmation when deleting files" step, and the logical problem can be mostly
understood here:
https://invent.kde.org/frameworks/kio/-/blob/a360462d5290200b27d874d1cb3895336942d55b/src/widgets/widgetsaskuseractionhandler.cpp#L304

Apparently I made the mistake of understanding deleting as something like
pressing the Delete button which should trash by default, but it's actually
file delete in this case. The "Reduce the size of the trash" step breaks
reproduction though, however I can't really see why isn't
`(util.usage(partitionSize + additionalSize)) >= percent` evaluating to true in
that case.

With that, I can confirm this to be an undesired data loss problem, even though
I personally consider only trashing to be safe without confirmation, and even
that is annoying to do accidentally as there isn't an interface for reverting
recent trashing operations, the user has to dig.

Reproducer:
1. Uncheck the "Deleting files or folders" confirmation setting.
2. Ensure the trash isn't full already (Beware: Just setting trash limit to
0.01% to make it full already doesn't work here)
3. Create a large test file: `truncate -s 32G test.file` (modify size as needed
to make sure it doesn't fit into the configured trash size limit)
4. Attempt to trash the test file
5. Observe the trashing operation being promoted to deletion which then gets
automatically confirmed

Issue is CONFIRMED, and it seems to be a problem in KIO, not in Dolphin, should
affect other products too.
Can't reproduce in Krusader though, this time trashing is just hanging, but
that's a matter belonging to Bug 486299 .

Suggesting bumping up Importance as this is a data loss concern.

-- 
You are receiving this mail because:
You are on the CC list for the bug.