[dolphin] [Bug 481401] On a slow network location, Dolphin allows two "new folder" modals then crashes

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=481401

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/742566e
                   |                            |b69e6bf46e7abb74e9ce9293c4b
                   |                            |3ed7e8
         Resolution|---                         |FIXED

--- Comment #13 from Felix Ernst <felixernst at kde.org> ---
Git commit 742566eb69e6bf46e7abb74e9ce9293c4b3ed7e8 by Felix Ernst, on behalf
of Akseli Lahtinen.
Committed on 11/05/2024 at 15:59.
Pushed by felixernst into branch 'master'.

Check if namejob is already being run before opening new createDirectory dialog

This is a fix for a bug where in network views (or otherwise slow
systems), pressing `Ctrl+Shift+N` multiple times opens multiple popup
windows and thus causes a crash when any of the popups is interacted
with after closing the topmost one. The problem is not the crash with
popups themselves, but that we're opening multiple popups in the first
place.

In regular views this works fine, since the `nameJob` does not take
long time at all and only one popup opens, immediately blocking the
shortcut.

In network views, the `nameJob` seems to take a while to run, since it
is loading info from network. If user spams `Ctrl+Shift+N` shortcut in
frustration, it starts more `nameJob`s and eventually when those jobs
are done, it opens multiple popups.

This code checks that if we're already running a `namejob`, we're very
likely waiting for the `createDir` popup to appear, so we don't do
anything until there is no more `nameJob` running. 

I've tested that it works in both network and regular Dolphin views.

M  +1    -1    CMakeLists.txt
M  +8    -2    src/dolphinmainwindow.cpp

https://invent.kde.org/system/dolphin/-/commit/742566eb69e6bf46e7abb74e9ce9293c4b3ed7e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.