[dolphin] [Bug 477425] Crash in UpdateItemStatesThread::run

[Méven]

https://bugs.kde.org/show_bug.cgi?id=477425

Méven <meven at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/d270700
                   |                            |c0ef42b6f1e1bef09bbf0bab59b
                   |                            |3e78d1
         Resolution|---                         |FIXED

--- Comment #17 from Méven <meven at kde.org> ---
Git commit d270700c0ef42b6f1e1bef09bbf0bab59b3e78d1 by Méven Car.
Committed on 24/03/2024 at 10:55.
Pushed by meven into branch 'master'.

versioncontrol: Prevent a use-after-free in UpdateItemStatesThread

UpdateItemStatesThread kept a pointer reference to m_plugin whose
lifetime was tied to VersionControlObserver parents.
On application shutdown it could happen the thread is still running when
the Observer is destroyed.

Make the plugin pointer a weak reference, allowing to stop the thread
when the plugin is gone.

M  +8    -4    src/views/versioncontrol/updateitemstatesthread.cpp
M  +2    -1    src/views/versioncontrol/updateitemstatesthread.h

https://invent.kde.org/system/dolphin/-/commit/d270700c0ef42b6f1e1bef09bbf0bab59b3e78d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.