[dolphin] [Bug 477739] Free space dropdown shows empty menu if Filelight is not installed

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=477739

--- Comment #4 from Felix Ernst <felixernst at kde.org> ---
Git commit 0d981e7b7df266c867004e23a169ba8cc13c8683 by Felix Ernst.
Committed on 08/07/2024 at 11:41.
Pushed by felixernst into branch 'master'.

Improve Filelight installation UX

Before this commit pressing the free space button when Filelight
is not installed would show a singular action called "Install
Filelight to View Disk Usage Statistics…". Pressing this button
would open the store page for Filelight. This is an okay user
experience, but we can do better.

This commit makes it so pressing the free space button when
Filelight is not installed shows an attractive UI that makes clear
that freeing up disk space can be accomplished nicely by installing
Filelight. The "Install Filelight…" button on this UI is connected
to PackageKit directly, so we do not need to show a separate store
like Discover and instead trigger an installation right then and
there. For this, the recently introduced DolphinPackageInstaller
KJob is used.

Installation progress is reported through the status bar similar to
the progress reporting of slowly loading directories or searches.
Installation failure or success is ultimately shown within Dolphin
as a passive notification above the view.

On Microsoft Windows or when PackageKit is not available, the
install button will only open a store page for Filelight.

M  +1    -0    src/CMakeLists.txt
M  +3    -0    src/config-dolphin.h.cmake
M  +1    -0    src/dolphinviewcontainer.cpp
M  +2    -2    src/global.h
M  +7    -0    src/statusbar/dolphinstatusbar.cpp
M  +7    -0    src/statusbar/dolphinstatusbar.h
M  +98   -11   src/statusbar/statusbarspaceinfo.cpp
M  +32   -0    src/statusbar/statusbarspaceinfo.h

https://invent.kde.org/system/dolphin/-/commit/0d981e7b7df266c867004e23a169ba8cc13c8683

-- 
You are receiving this mail because:
You are on the CC list for the bug.