[dolphin] [Bug 453933] Navigation moves reversely in RTL mode using arrow keys

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=453933

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/03de142
                   |                            |a799815e2259aa75831cbbd3154
                   |                            |a02942

--- Comment #3 from Felix Ernst <felixernst at kde.org> ---
Git commit 03de142a799815e2259aa75831cbbd3154a02942 by Felix Ernst, on behalf
of Felix Ernst.
Committed on 30/01/2024 at 16:08.
Pushed by felixernst into branch 'master'.

Improve arrow key navigation for right-to-left languages

While using right-to-left languages most of Dolphin is mirrored.
However, the logic of what happens when the arrow keys are pressed to
move between items in the main view was never adapted to account for
that. Basically nothing works as expected because of this. It's more
like dealing with a psychopath who misinterprets every command you give:
Left is right, right is left, up is most of the time right but sometimes
not, down is most the time left but sometimes not.

This commit fixes and adapts the logic if a right-to-left layout is used.
This fully fixes icon view mode and improves compact view mode, though
compact view mode still has more issues which aren't addressed here.

This work for the benefit of the minority that use right-to-left
languages both in Europe and the world is sponsored by NLnet and the
European Commission which I think is beautfiul.

M  +28   -4    src/kitemviews/kitemlistcontroller.cpp

https://invent.kde.org/system/dolphin/-/commit/03de142a799815e2259aa75831cbbd3154a02942

-- 
You are receiving this mail because:
You are on the CC list for the bug.